[Debug] Print only description of value types that conform to CustomStringConvertible #84677
+19
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for lldb, where the
po
command for Swift is implemented in_DebuggerSupport.stringForPrintObject
.Up to now, a Swift struct which conforms to
CustomStringConvertible
will print both itsdescription
, and also recursively print its internals.This differs from a class, where only the
description
is printed.This changes
stringForPrintObject
to print only thedescription
of value types that conform toCustomStringConvertible
(ordebugDescription
forCustomDebugStringConvertible
) – unless the type conforms toCustomReflectable
, in which case its children are printed.This issue was raised for
FilePath
, which prints excessively verbosely, like so:rdar://161919005