[Performance Hints] Implement check for existential any #84684
+391
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
This commit introduces a performance hint check that warns on the use of existential any in variable declarations, function and closure parameters and return, and typealiases.
aviralg
force-pushed
the
perf-hint/existential-any
branch
from
7217eb3 to
13a5c2d
Compare
aviralg
requested review from
hborla,
slavapestov,
xedin and
DougGregor
as code owners
|
@swift-ci test |
slavapestov
requested changes
Oct 6, 2025
lib/Sema/PerformanceHints.cpp
Outdated
| return true; | ||
| } | ||
|
|
||
| bool visitTupleType(TupleType *TT) { |
There was a problem hiding this comment.
Using TypeVisitor for this is incorrect because you're going to miss a lot of cases. For example, a nominal type might have a parent, which you're not visiting at all:
struct Outer<T> {
struct Inner {}
}
Outer<any P>.Inner
Please use Type.findIf() or Type.visit() instead.
There was a problem hiding this comment.
Fixed in #8ab27f Thanks for the example, added it as a test case.
artemcm
reviewed
Oct 6, 2025
|
@swift-ci test |
artemcm
reviewed
Oct 6, 2025
artemcm
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a performance hint check that warns on the use of existential any in variable declarations, function and closure parameters and return, and typealiases.