[Evaluator] Avoid emitting duplicate "through reference here" notes #84698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filter out any duplicate notes to help cut down on the noise for request cycle diagnostics. Some of the note locations here still aren't great, but this at least stops us from repeating them for each intermediate request.
Make it a bit clearer that these are steps in the request cycle.
hamishknight
requested review from
hborla,
slavapestov,
xedin,
AnthonyLatsis and
CodaFi
as code owners
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter out any duplicate notes to help cut down on the noise for request cycle diagnostics. Some of the note locations here still aren't great, but this at least stops us from repeating them for each intermediate request.