[cxx-interop] Avoid crashing upon invalid function template instantiation #84724
+113
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have -suppress-warnings and -suppress-remarks; this patch adds support for suppressing notes too. Doing so is useful for -verify tests where we don't really care about the emitted notes.
j-hui
requested review from
zoecarver,
egorzhdan,
Xazax-hun,
fahadnayyar,
susmonteiro,
hnrklssn,
artemcm,
tshortli,
beccadax,
ian-twilightcoder,
hborla,
slavapestov,
xedin and
DougGregor
as code owners
|
@swift-ci please test |
hnrklssn
approved these changes
Oct 7, 2025
…tion We were previously not handling cases where the instantiation of the **declaration** of a function template is valid, but the instantiation of its **definition** is invalid (e.g., because it contains an invalid static_cast() or static_assert()). This patch teaches ClangImporter to correctly diagnose these as compiler errors, rather than simply crashing. rdar://137456897
j-hui
force-pushed
the
invalid-func-tmpl-inst
branch
from
ea8ee1b to
36ba535
Compare
We were not handling nullptrs consistently. This shouldn't actually change the behavior for any known case but makes the error handling logic a little more explicit and robust.
|
@swift-ci please test |
Xazax-hun
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously not handling cases where the instantiation of the
declaration of a function template is valid, but the instantiation
of its definition is invalid (e.g., because it contains an invalid
static_cast() or static_assert()). This patch teaches ClangImporter to
correctly diagnose these as compiler errors, rather than simply
crashing.
rdar://137456897
Builds on #84723