Skip to content

[WIP][RBI]: possible fix for class method hole #84727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −2
Draft

[WIP][RBI]: possible fix for class method hole #84727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/SILOptimizer/Utils/SILIsolationInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,9 @@ bool DeclRefExprAnalysis::compute(Expr *expr) {
return Action::Stop();
}

if (isa<CoerceExpr, MemberRefExpr, ImplicitConversionExpr, IdentityExpr>(
expr)) {
// TODO: is this right?
if (isa<CoerceExpr, MemberRefExpr, ImplicitConversionExpr, IdentityExpr,
LoadExpr, SubscriptExpr, InOutExpr>(expr)) {
parentAnalysis.lookThroughExprs.push_back(expr);
return Action::Continue(expr);
}
Expand Down
13 changes: 13 additions & 0 deletions test/Concurrency/transfernonsendable_sending_params.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3079,3 +3079,16 @@ func testNonSendableCaptures(ns: NonSendableKlass, a: isolated MyActor) {
let _ = ns
}
}

// https://github.com/swiftlang/swift/issues/84376

@MainActor
class NonFinalMainActorClass {
var nonSendableState: [NonSendableKlass] = []

func testClassMethodSubscriptLookupPropagatesIsolation() {
let alias = nonSendableState[0]
transferArg(alias) // expected-warning {{sending 'alias' risks causing data races}}
// expected-note @-1 {{main actor-isolated 'alias' is passed as a 'sending' parameter; Uses in callee may race with later main actor-isolated uses}}
}
}