[irgen] Implement support for alloc_stack non_nested. #85604
+620
−136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means I just added the flag and added support for cloning/printing/serializing the bit on alloc_stack.
…ed stack allocations.
Contributor
Author
|
@swift-ci smoke test |
…nctions for Instructions, Arguments, and add a variant for Values. This also required me to change how we handled which instruction/argument we emit an error about in the verifier. Previously we were using two global variables that we made nullptr to control which thing we emitted an error about. This was unnecessary. Instead I added a little helper struct that internally controls what we will emit an error about and an external "guard" RAII struct that makes sure we push/pop the instruction/argument we are erroring upon correctly.
… when verifying that we end scope instructions. We do this since we need to be able to handle instructions that may have two different results that independently need their scopes lifetime to be ended.
gottesmm
force-pushed
the
alloc_stack_non_nested
branch
from
0870f81 to
c2ad52e
Compare
Contributor
Author
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just beginning testing