Disambiguate the reference to remquo on Windows #85609
Open
+58
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
For swiftlang#85606 This is to fix an overload ambiguity error that occur because the C/C++ types double and long double are typealias to each other in Swift on Windows and the system C++ header cmath.h defines a remquo function overload for long double which conflicts with the one in the C header corecrt_math.h in Swift.
Contributor
Author
|
@swift-ci please test |
compnerd
reviewed
Nov 20, 2025
| @@ -295,7 +295,11 @@ public func lgamma(_ x: ${T}) -> (${T}, Int) { | |||
| @_transparent | |||
| public func remquo(_ x: ${T}, _ y: ${T}) -> (${T}, Int) { | |||
| var quo = Int32(0) | |||
| #if !os(Windows) | |||
Member
There was a problem hiding this comment.
This problem should occur for any platform that doesn't differentiate long double from double right?
I think that rather than differentiating this on os(Windows), we want to use something to differentiate this based on sizeof(long double) == sizeof(double).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #85606
This is to fix an overload ambiguity error that occur because the
C/C++ types double and long double are typealias to each other in
Swift on Windows and the system C++ header cmath.h defines a remquo
function overload for long double which conflicts with the one in the
C header corecrt_math.h in Swift.