SIL: make a linkage mismatch during de-serialization a human readable diagnostic #85628
+40
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci smoke test |
slavapestov
reviewed
Nov 20, 2025
Contributor
slavapestov
left a comment
slavapestov
left a comment
There was a problem hiding this comment.
I won't insist on a test case since I'm assuming it's too much of a pain in the ass, but if it's at all possible...
include/swift/AST/DiagnosticsSIL.def
Outdated
| (StringRef, Type, Type)) | ||
|
|
||
| ERROR(deserialize_function_linkage_mismatch,Fatal, | ||
| "linkage mismatch of function '%0', declared as %1but expected as %2", |
Contributor
There was a problem hiding this comment.
I think you want to add a space between then %1 and but
lib/SIL/IR/SILPrinter.cpp
Outdated
| static StringRef getLinkageString(SILLinkage linkage) { | ||
| StringRef swift::getLinkageString(SILLinkage linkage) { | ||
| switch (linkage) { | ||
| case SILLinkage::Public: return "public "; |
Contributor
There was a problem hiding this comment.
Ok I see, this already has a space at the end, but that's really weird, can you please change it to not do that? There is only one caller of getLinkageString(), and it's printLinkage(), which could easily be changed to print the space.
Member
|
Thanks for improving this erik! :D |
… diagnostic Although this error can only happen when tinkering with the stdlib's runtime functions, it's nice to get a readable error message. So far, the compiler just crashed later without a hint to the original problem.
eeckstein
force-pushed
the
linkage-mismatch-error
branch
from
c2545ad to
9d02917
Compare
Contributor
Author
|
@swift-ci smoke test |
Contributor
|
Thank you for addressing the review feedback! LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although this error can only happen when tinkering with the stdlib's runtime functions, it's nice to get a readable error message. So far, the compiler just crashed later without a hint to the original problem.