Sema: Add debug code to check if certain predicates are transitive #86356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
check-if-transitive
branch
from
0c7a407 to
48e6e3f
Compare
slavapestov
commented
Jan 7, 2026
|
|
||
| // Pick the disjunction with the smallest number of favored, then active | ||
| // choices. | ||
| auto bestDisjunction = std::min_element( |
Contributor
Author
There was a problem hiding this comment.
Note the indentation changes here which is why it's a big diff but I didn't change anything in the body of the lambda.
Contributor
Author
|
@swift-ci Please smoke test |
slavapestov
changed the title
Contributor
Author
|
@swift-ci Please smoke test |
slavapestov
force-pushed
the
check-if-transitive
branch
from
d23ac50 to
808157b
Compare
Contributor
Author
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some debugging code in two places:
This will remain off by default because it calls the predicate
O(n^2)times in any case, but also for now, neither predicate is actually transitive so the stdlib doesn't build with these on.