[cxx-interop] Synthesize subscript without requiring ClangNode #86360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-hui
requested review from
Xazax-hun,
beccadax,
egorzhdan,
hnrklssn,
ian-twilightcoder and
susmonteiro
as code owners
Contributor
Author
|
@swift-ci please test |
hnrklssn
approved these changes
Jan 7, 2026
This scenario happens when a derived class inherits operator[] from a base class. The derived class's operator[] is a synthesized shim, which (currently) does not have a ClangNode associated with it. This prevents an assertion failure in SubscriptDecl::createImported(). rdar://167701851
j-hui
force-pushed
the
inherited-subscript
branch
from
0632661 to
9de4cf8
Compare
Contributor
Author
|
@swift-ci please test |
Xazax-hun
approved these changes
Jan 8, 2026
Contributor
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This scenario happens when a derived class inherits operator[] from a base class. The derived class's operator[] is a synthesized shim, which (currently) does not have a ClangNode associated with it.
This prevents an assertion failure in SubscriptDecl::createImported().
rdar://167701851