[6.3][AST] ASTPrinter: Don't attempt to print nonisolated(nonsending) on…
#86365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… non-function parameters Don't look through sugar when checking whether to print `nonisolated(nonsending)` in parameter positions, because underlying types would already be marked appropriately and parameters themselves doesn't require the modifier transfer even when the sugar is stripped. Resolves: rdar://167050741 (cherry picked from commit df109f8)
Contributor
Author
|
@swift-ci please test |
DougGregor
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… non-function parameters
Explanation:
Don't look through sugar when checking whether to print
nonisolated(nonsending)in parameter positions, because underlying types would already be marked appropriately and parameters themselves doesn't require the modifier transfer even when the sugar is stripped.Resolves: rdar://167050741
Main branch PR: [AST] ASTPrinter: Don't attempt to print
nonisolated(nonsending)on… #86334Risk: Low. Affects only typealiases to async functions referenced in parameter positions when printed in swiftinterfaces.
Reviewed By: @hborla
Testing: Added new test-cases to the suite.
(cherry picked from commit df109f8)