Fix package import warning for macro attributes on package declarations #86376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
checkAttachedMacroAccess()to track import usage for macro attributes on package declarationsProblem
When a macro attribute from an external module is applied to a
package-level declaration, the compiler incorrectly emits:AccessControlCheckertracks import usage for types, global actors, and availability attributes, but not for macro attributes. Thepubliccase works because it has more comprehensive tracking, butpackagedeclarations have gaps.Solution
Add
checkAttachedMacroAccess()toAccessControlCheckerBasefollowing the same pattern ascheckGlobalActorAccess(). This iterates through attached macro attributes on package declarations and callsrecordRequiredImportAccessLevelForDecl()to register the import usage.Test Plan
Reproduction repo: https://github.com/hi2gage/swift-package-macro-import-warning-repro
Before fix:
After fix:
No warning (clean build)
Related Issue
Fixes #86375