Skip to content

Conversation

danny1113
Copy link
Contributor

  • Move arch string literal to a global variable cpuArch.
  • Refactor: Let compiler to infer the array type.

@cmcgee1024
Copy link
Member

Thanks @danny1113

This is a good clean up of some ugly code. I'm going to run the tests on this, but will need to wait a bit longer to merge it since we're trying to close off the 0.4.0 release leaving the branch open for last minute stability fixes.

@cmcgee1024
Copy link
Member

@danny1113 can you reformat the new code following the instructions in the failed workflow here: https://github.com/swiftlang/swiftly/actions/runs/13129413293/job/36656660591?pr=216

@cmcgee1024
Copy link
Member

@swift-ci test macOS

Copy link
Member

@cmcgee1024 cmcgee1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me and the checks are all passing. I'm not approving and merging it for now since there is a freeze on the main branch.

@danny1113
Copy link
Contributor Author

This all looks good to me and the checks are all passing. I'm not approving and merging it for now since there is a freeze on the main branch.

Got it! Thanks!

@cmcgee1024 cmcgee1024 merged commit 2531b9f into swiftlang:main Mar 5, 2025
19 checks passed
@cmcgee1024
Copy link
Member

Thanks @danny1113 for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants