Skip to content

Conversation

rauhul
Copy link
Member

@rauhul rauhul commented Mar 7, 2025

Swiftly interpolates some file URLs directly into user facing output leading to messages like 'The file file:///Volumes/... has been...' which needlessly contains the url schema prefix file://. This change updates Swiftly to use URL.path for better user output.

Copy link
Member

@cmcgee1024 cmcgee1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I suspect that the formatting check will fail on line 131 of MacOS.swift.

Swiftly interpolates some file URLs directly into user facing output
leading to messages like 'The file `file:///Volumes/...` has been...'
which needlessly contains the url schema prefix `file://`. This change
updates Swiftly to use URL.path for better user output.
@rauhul rauhul force-pushed the rauhul/pretty-url branch from 2c93cb6 to c802171 Compare March 7, 2025 18:26
@cmcgee1024
Copy link
Member

@swift-ci test macOS

@cmcgee1024 cmcgee1024 merged commit fc84878 into swiftlang:main Mar 7, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants