Migrate swiftly to swift testing #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove extraneous HTTP requests during most testing Fully sandbox and mock GPG key import and verification
…needed for mocking
… to Trait instead of var
…r lists and static references
…ithin test cases Increase HTTP timeouts to help with timeouts in CI
Run HTTPClientTests serially to avoid network contention
Bump the default http client read timeout
cmcgee1024
changed the title
…move unused Response
…t_testing_migration
|
@swift-ci test macOS |
jakepetroules
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, this is a good opportunity to refactor all of the shared mutable state into
a context that can be mocked by the tests.
Provide more complete context for mocking, including current working directory,
and shell.
Clean up any temporary files that are used in the process of testing or in production.
Completely isolate the tests from the network except for the ones that explicitly
test it, such as the HTTPClientTests.
Use new Swift Testing features, such as test scoping traits and parameterized tests
to reduce level of nested blocks within the tests, and also improve parallel test
execution.