Migrate swiftly to Swift 6 with concurrency checks #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test macOS |
…t6_concurrency
|
@swift-ci test macOS |
plemarquand
reviewed
Apr 10, 2025
| /// - swift-a.b-DEVELOPMENT-SNAPSHOT | ||
| struct ReleaseSnapshotParser: ToolchainSelectorParser { | ||
| static let regex: Regex<(Substring, Substring, Substring, Substring?)> = | ||
| static func regex() -> Regex<(Substring, Substring, Substring, Substring?)> { |
There was a problem hiding this comment.
What is the motivation to making this a function? We'll incur the regex creation cost every call. Could this be a lazy static instead?
static let regex: Regex = {
return try! Regex("^(?:swift-)?([0-9]+)\\.([0-9]+)-(?:snapshot|DEVELOPMENT-SNAPSHOT|SNAPSHOT)(?:-([0-9]{4}-[0-9]{2}-[0-9]{2}))?(?:-a)?$")
}
There was a problem hiding this comment.
No, it's because Regex is not Sendable in its current state. A lot of swift code just constructs regexes where they are used, so this would be no different. Maybe someday Regex can be Sendable.
There was a problem hiding this comment.
There's a forum thread on this topic:
https://forums.swift.org/t/should-regex-be-sendable/69529/15
|
|
||
| public class TestOutputHandler: SwiftlyCore.OutputHandler { | ||
| public actor TestOutputHandler: SwiftlyCore.OutputHandler { | ||
| public var lines: [String] |
There was a problem hiding this comment.
nit:
Suggested change
| public var lines: [String] | |
| public private(set) var lines: [String] |
plemarquand
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.