Model additional system commands #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Model the pkgbuild command with the usual structure used for other commands. Provide a custom string convertible implementation for configuration so that the configuration can be easily converted into a string for logging and comparison purposes. Create a runEcho() implementation for the build swiftly release script so that commands can output their command-line to the log for reproducibility.
|
@swift-ci test macOS |
cmcgee1024
changed the title
|
@swift-ci test macOS |
|
@swift-ci test macOS |
plemarquand
approved these changes
Apr 29, 2025
Sources/SwiftlyCore/Commands.swift
Outdated
| var args: [String] = [] | ||
|
|
||
| for option in self.options { | ||
| args += option.args() |
There was a problem hiding this comment.
nit: favour .append(contentsOf:) over += here, as .append is a more specialized implementation that won't create an intermediate array.
There was a problem hiding this comment.
Thanks, I've replaced them all with an equivalent append method.
| extension Arguments: CustomStringConvertible { | ||
| public var description: String { | ||
| let normalized: [String] = self.storage.map(\.description).map { | ||
| if $0.contains(" ") { |
There was a problem hiding this comment.
nit: could be shortened to a ternary
There was a problem hiding this comment.
Done, thanks for the suggestion.
plemarquand
approved these changes
Apr 29, 2025
Replace if with ternary expression
|
@swift-ci test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model the pkgbuild command with the usual structure used for other commands.
Provide a custom string convertible implementation for configuration so that the
configuration can be easily converted into a string for logging and comparison
purposes.
Create a runEcho() implementation for the build swiftly release script so that
commands can output their command-line to the log for reproducibility.
Add a model for the Linux getent command. Provide a convenience entries() method
that provides a table of the entries for better ease of use.
Model a small subset of the git command for use in the build swiftly release script and
testing of it.