Add an option to self-update to provide the swiftly version to update #370
Conversation
cmcgee1024
requested review from
etcwilde,
justice-adams-apple and
shahmishal
as code owners
|
|
||
| ``` | ||
| swiftly self-update [--assume-yes] [--verbose] [--version] [--help] | ||
| swiftly self-update [--assume-yes] [--verbose] [--version] [--help] |
There was a problem hiding this comment.
Thanks, the documentation generator is homegrown, and naive. This seems minor enough that I wanted to keep the change to another PR, or possibly adopt the revision of it that's now available in the swift argument parser project.
| downloadURL = URL(string: "https://download.swift.org/swiftly/linux/swiftly-\(version)-x86_64.tar.gz") | ||
| #elseif arch(arm64) | ||
| downloadURL = URL(string: "https://download.swift.org/swiftly/linux/swiftly-\(version)-aarch64.tar.gz") | ||
| #endif |
There was a problem hiding this comment.
Should this throw an error if we somehow get here and don't know what we're downloading?
As it stands, I think this will end up running the update based on getCurrentSwiftlyRelease() since downloadURL won't get set, even though a version was specified.
There was a problem hiding this comment.
I've added fatal errors in the unsupported cases.
| try await SwiftlyTests.withTestHome { | ||
| try await SwiftlyTests.withMockedSwiftlyVersion(latestSwiftlyVersion: latestVersion) { | ||
| let updatedVersion = try await SelfUpdate.execute(SwiftlyTests.ctx, verbose: true) | ||
| let updatedVersion = try await SelfUpdate.execute(SwiftlyTests.ctx, verbose: true, version: nil) |
There was a problem hiding this comment.
@cmcgee1024 do we want a test specifying the version to cover the new code path?
There was a problem hiding this comment.
Thanks, I've added more test coverage for this
3 participants
This can be useful for testing the self-update to pre-releases that may not
yet be published as the current in the swift.org API because they are undergoing
testing.