Skip to content

Fix shared mutable state problem with install test #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025
Merged

Fix shared mutable state problem with install test #399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions Tests/SwiftlyTests/InstallTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,17 +320,17 @@ import Testing
try? FileManager.default.removeItem(atPath: pipePath)
}

var receivedMessages: [ProgressInfo] = []
let decoder = JSONDecoder()
var installCompleted = false

let readerTask = Task {
guard let fileHandle = FileHandle(forReadingAtPath: pipePath) else { return }
var receivedMessages: [ProgressInfo] = []

guard let fileHandle = FileHandle(forReadingAtPath: pipePath) else { throw SwiftlyError(message: "Unable to open file handle at \(pipePath)") }
defer { fileHandle.closeFile() }

var buffer = Data()

while !installCompleted {
while true {
let data = fileHandle.availableData
if data.isEmpty {
try await Task.sleep(nanoseconds: 100_000_000)
Expand All @@ -347,13 +347,14 @@ import Testing
if let progress = try? decoder.decode(ProgressInfo.self, from: lineData) {
receivedMessages.append(progress)
if case .complete = progress {
installCompleted = true
return
return receivedMessages
}
}
}
}
}

return receivedMessages
}

let installTask = Task {
Expand All @@ -364,10 +365,10 @@ import Testing
])
}

await withTaskGroup(of: Void.self) { group in
group.addTask { try? await readerTask.value }
group.addTask { try? await installTask.value }
}
let readerResult = await readerTask.result
try await installTask.value

let receivedMessages = try readerResult.get()

#expect(!receivedMessages.isEmpty, "Named pipe should receive progress entries")

Expand Down