Use Subprocess for process management #410
Conversation
cmcgee1024
requested review from
shahmishal,
justice-adams-apple and
etcwilde
as code owners
Sources/SwiftlyCore/Platform.swift
Outdated
| if let env { | ||
| process.environment = env | ||
| } | ||
| // TODO: figure out how to set the process group |
There was a problem hiding this comment.
The PlatformOptions structure has some APIs you might be able to use for this.
I'm not that familiar with tcsetpgrp -- would setgid be sufficient here? (there's a PlatformOptions.processGroupID API for that)
Alternatively, there's a PlatformOptions.preSpawnProcessConfigurator closure on Linux/Android/BSD which runs between fork and exec, where you could do this. (But on Darwin, posix_spawn is used, and PlatformOptions.preSpawnProcessConfigurator runs before fork so I don't think you'd have a good place to do it)
Worth reaching out to @iCharlesHu to see if tcsetpgrp might be something worth having dedicated API for.
There was a problem hiding this comment.
This was here because Foundation Process would automatically assign a new process group to child processes, and we wanted to be able to have the terminal control the child process that is in the foreground. With the default behaviour of swift-subprocess being that the child is in the current process's group this is no longer needed, which is a nice bonus of this new API.
…e tools Forward standard error for runProgramOutput in case there are useful error messages
No description provided.