Detect Swiftly Installation #1772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
award999
reviewed
Aug 7, 2025
| @@ -259,7 +259,7 @@ async function getQuickPickItems( | |||
| } | |||
| // Various actions that the user can perform (e.g. to install new toolchains) | |||
| const actionItems: ActionItem[] = []; | |||
| if (process.platform === "linux" || process.platform === "darwin") { | |||
| if (Swiftly.isSupported() && !(await Swiftly.isInstalled())) { | |||
There was a problem hiding this comment.
praise: great idea to reuse the existing logic
roulpriya
force-pushed
the
do-not-show-swiftly-install
branch
from
dd1a194 to
1b48042
Compare
matthewbastien
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Detect Swiftly Installation and hide the Install Swiftly.. in toolchain picker
Issue: #1771
Tasks