Prompt for cancellation when starting test run while one is in flight #1774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
plemarquand
force-pushed
the
cancel-running-tests
branch
2 times, most recently
from
68c8eb2 to
7a9491c
Compare
award999
approved these changes
Aug 8, 2025
mzhfei
reviewed
Aug 9, 2025
If a test run is already in progress and another one is started VS Code will queue it and start the second run once the first has finished. Implement cancellation logic that prompts the user to cancel the active test run if one is in flight. If they chose to cancel the dialog, the second test run is not queued. If they do chose to cancel the active test run it is stopped and the new one starts immediately. Issue: swiftlang#1748
plemarquand
force-pushed
the
cancel-running-tests
branch
11 times, most recently
from
a759e96 to
b975b61
Compare
plemarquand
force-pushed
the
cancel-running-tests
branch
from
b975b61 to
4e64793
Compare
rbenegal
approved these changes
Aug 12, 2025
matthewbastien
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a test run is already in progress and another one is started VS Code will queue it and start the second run once the first has finished.
Implement cancellation logic that prompts the user to cancel the active test run if one is in flight. If they chose to cancel the dialog, the second test run is not queued. If they do chose to cancel the active test run it is stopped and the new one starts immediately.
Issue: #1748
Tasks
Documentation has been updated