Cleanup circular dependency in WorkspaceContext/FolderContext #1779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Break a circular dependency between WorkspaceContext and FolderContext. While WorkspaceContext can create FolderContexts the FolderContext doesn't need to know about WorkspaceContexts. Also cleans up some promises that were being implicitly run by being prefixed with `void`.
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
|
I'm going to break this in to smaller blocks of work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Break a circular dependency between WorkspaceContext and FolderContext. While WorkspaceContext can create FolderContexts the FolderContext doesn't need to know about WorkspaceContexts.
Also cleans up some promises that were being implicitly run by being prefixed with
void.Tasks
Required tests have been writtenAdded an entry to CHANGELOG.md if applicable