Remove temp folder from WorkspaceContext #1781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an effort to pair down WorkspaceContext and the dependencies that need to be threaded through the application from it, remove the common tempFolder from it and grab a reference to it as needed. A large portion of this PR is refactoring the `runScript` commandand ensuring nothing broke by adding tests.
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
matthewbastien
approved these changes
Aug 14, 2025
rbenegal
reviewed
Aug 14, 2025
rbenegal
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In an effort to pair down WorkspaceContext and the dependencies that need to be threaded through the application, remove the common tempFolder from it and create the common temp folder as required in dependencies.
A large portion of this PR is refactoring the
runScriptcommand and ensuring nothing broke by adding tests.Tasks
Added an entry to CHANGELOG.md if applicable