Update BuildFlags.buildDirectoryFromWorkspacePath method for scratch-path#2032
Merged
plemarquand merged 2 commits intoswiftlang:mainfrom Feb 6, 2026
Merged
Update BuildFlags.buildDirectoryFromWorkspacePath method for scratch-path#2032plemarquand merged 2 commits intoswiftlang:mainfrom
plemarquand merged 2 commits intoswiftlang:mainfrom
Conversation
plemarquand
requested changes
Jan 12, 2026
Contributor
|
Looks great! Just one comment about validation since we've had issues reported in he past where users have misconfigured arguments, and they're often hard to track down unless we guard against it defensively. |
Contributor
Author
@plemarquand I have added the necessary validations which were mentioned. |
ce7ef2e to
db0ad1a
Compare
plemarquand
approved these changes
Feb 6, 2026
Contributor
plemarquand
left a comment
There was a problem hiding this comment.
Thanks for this! Sorry for the delay, we needed to fix a Windows CI issue and I had to rebase to fix a merge conflict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
extract(scratchpath())method to detectscratch-pathandbuildpathargs.buildDirectoryFromWorkspacePathmethod with appropriate precedence.Fixes: #2022
Tasks