Always notify user when an unexpected setting value is found#2086
Merged
plemarquand merged 3 commits intoswiftlang:mainfrom Feb 5, 2026
Merged
Always notify user when an unexpected setting value is found#2086plemarquand merged 3 commits intoswiftlang:mainfrom
plemarquand merged 3 commits intoswiftlang:mainfrom
Conversation
We started validating that setting values were of the expected type in da0e04c however the user was only notified with a popup if the malformed setting was used during extension activation. A user recently encountered an issue with a malfored `swift.sourcekit-lsp.backgroundIndexing` setting. Because sourcekit-lsp is set up so its creation doesn't block extension activation, this error never bubbled up to the activation error handler, and they were not notified. Instead notify the user immediately when we detect the malformed setting. The malformed value is cached so we only notify the first time we detect it, avoiding spamming the user with prompts.
plemarquand
requested review from
0xTim,
adam-fowler and
award999
as code owners
matthewbastien
approved these changes
Feb 5, 2026
Co-authored-by: Matthew Bastien <matthew_bastien@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We started validating that setting values were of the expected type in da0e04c however the user was only notified with a popup if the malformed setting was used during extension activation.
A user recently encountered an issue with a malfored
swift.sourcekit-lsp.backgroundIndexingsetting. Because sourcekit-lsp is set up so its creation doesn't block extension activation, this error never bubbled up to the activation error handler, and they were not notified.Instead notify the user immediately when we detect the malformed setting. The malformed value is cached so we only notify the first time we detect it, avoiding spamming the user with prompts.
Tasks
Required tests have been writtenDocumentation has been updated