Skip to content

Fixed Dockerfile build errors#2090

Open
thePianoKid wants to merge 1 commit intoswiftlang:mainfrom
thePianoKid:fix-dockerfile
Open

Fixed Dockerfile build errors#2090
thePianoKid wants to merge 1 commit intoswiftlang:mainfrom
thePianoKid:fix-dockerfile

Conversation

@thePianoKid
Copy link
Contributor

Description

The manual tests that I ran while QAing #2068 were flawed. When I would rebuild and open VS Code in a container, VS Code seems to have been caching some changes. I didn't realize that the COPY ../nvmrc /tmp/.nvmrc change that I wrote would cause the build to fail with COPY failed: forbidden path outside the build context: ../nvmrc ().

When I ran Dev Containers: Rebuild Without Cache and Reopen in Container, I found this issue, and rectified it in this PR.

Issue: Addresses a bug introduced in #2068

To test this change, run Dev Containers: Rebuild Without Cache and Reopen in Container, and make sure the Docker container builds successfully.

Tasks

  • Required tests have been written
  • Documentation has been updated
  • Added an entry to CHANGELOG.md if applicable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants