Skip to content

PackageToJS: Report stack trace on proc_exit #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025
Merged

PackageToJS: Report stack trace on proc_exit #355

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f04cfe5
PackageToJS: Fix rendered indentation in test.js
kateinoigakukun May 7, 2025
67c9782
PackageToJS: Report stack trace on `proc_exit`
kateinoigakukun May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions Plugins/PackageToJS/Templates/bin/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,12 @@ const harnesses = {
let options = await nodePlatform.defaultNodeSetup({
args: testFrameworkArgs,
onExit: (code) => {
if (code !== 0) { return }
if (code !== 0) {
const stack = new Error().stack
console.error(`Test failed with exit code ${code}`)
console.error(stack)
return
}
// Extract the coverage file from the wasm module
const filePath = "default.profraw"
const destinationPath = args.values["coverage-file"] ?? filePath
Expand All @@ -52,9 +57,9 @@ const harnesses = {
writeFileSync(destinationPath, profraw);
}
},
/* #if USE_SHARED_MEMORY */
/* #if USE_SHARED_MEMORY */
spawnWorker: nodePlatform.createDefaultWorkerFactory(preludeScript)
/* #endif */
/* #endif */
})
if (preludeScript) {
const prelude = await import(preludeScript)
Expand Down