Skip to content

Remove redundant catch block for any Error #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
+3 −7
Merged

Remove redundant catch block for any Error #360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions Sources/JavaScriptKit/FundamentalObjects/JSClosure.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,19 +167,15 @@ private func makeAsyncClosure(
struct Context: @unchecked Sendable {
let resolver: (JSPromise.Result) -> Void
let arguments: [JSValue]
let body: (sending [JSValue]) async throws -> JSValue
let body: (sending [JSValue]) async throws(JSException) -> JSValue
}
let context = Context(resolver: resolver, arguments: arguments, body: body)
Task {
do {
do throws(JSException) {
let result = try await context.body(context.arguments)
context.resolver(.success(result))
} catch {
if let jsError = error as? JSException {
context.resolver(.failure(jsError.thrownValue))
} else {
context.resolver(.failure(JSError(message: String(describing: error)).jsValue))
}
context.resolver(.failure(error.thrownValue))
}
}
}.jsValue()
Expand Down