BridgeJS: Change @JS init
to generate static init()
methods instead of constructor
in JS
#409
+308
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
@JS init
to generate staticinit()
methods instead of direct constructors to separate two distinct Swift class instantiation patterns.Problem
Previously,
new SwiftClass()
was used for both:@JS init
constructorsThese two operations should not share the same API as they have fundamentally different semantics.
Solution
@JS init
now generates staticinit()
methods for Swift constructor callsnew SwiftClass()
is reserved for lifting Swift instances returned from Swift functions@JS init
constructorsChanges on generated interface