CMake: Enable WMO for Release builds #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new interpreter heavily benefits from WMO and it's even slower than the old one without it. This change enables WMO for Release builds for CMake builds as it's not enabled by default. Use `CMAKE_Swift_COMPILATION_MODE` if CMake 3.29 or newer is used, and fall back to `add_compile_options` if older. https://cmake.org/cmake/help/latest/prop_tgt/Swift_COMPILATION_MODE.html
kateinoigakukun
force-pushed
the
katei/wmo-cmake
branch
from
32ddc49 to
c7a6f9b
Compare
kateinoigakukun
added a commit
to kabiroberai/swift
that referenced
this pull request
Oct 13, 2024
This release includes a fix to the build system that enables WMO for release builds. swiftwasm/WasmKit#146
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new interpreter heavily benefits from WMO and it's even slower than the old one without it. This change enables WMO for Release builds for CMake builds as it's not enabled by default.
Use
CMAKE_Swift_COMPILATION_MODEif CMake 3.29 or newer is used, and fall back toadd_compile_optionsif older.https://cmake.org/cmake/help/latest/prop_tgt/Swift_COMPILATION_MODE.html