Skip to content

Conversation

MaxDesiatov
Copy link
Member

@MaxDesiatov MaxDesiatov commented Oct 10, 2025

See threads proposal explainer for more details.

These instructions are shimmed with existing non-atomic loads and stores for now, which seems reasonable as we can't spawn any threads yet. I've also added #include <stdatomic.h> placeholder to _CWasmKit, which we'll use for the actual implementation in a future PR.

@MaxDesiatov MaxDesiatov changed the title Threads: parsing of atomic instructions Threads: parsing of load/store atomic instructions Oct 10, 2025
@MaxDesiatov MaxDesiatov marked this pull request as ready for review October 10, 2025 11:38
@MaxDesiatov MaxDesiatov changed the title Threads: parsing of load/store atomic instructions Threads: parsing/execution of atomic load/store instructions Oct 10, 2025
@MaxDesiatov MaxDesiatov changed the title Threads: parsing/execution of atomic load/store instructions Threads: parsing of atomic load/store instructions Oct 10, 2025
Copy link
Member

@kateinoigakukun kateinoigakukun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect we need real atomicity to pass the test suite but I think it's still a good starting point.

Would you mind adding a feature flag to gate it behind?

@MaxDesiatov
Copy link
Member Author

MaxDesiatov commented Oct 10, 2025

I expect we need real atomicity to pass the test suite but I think it's still a good starting point.

Correct, that's why the test suite isn't enabled yet, and it apparently has some new WAST directives that we'll have to implement first.

Would you mind adding a feature flag to gate it behind?

You mean WasmFeatureSet? That one already has threads property.

@MaxDesiatov MaxDesiatov merged commit 8eed37f into main Oct 10, 2025
16 checks passed
@MaxDesiatov MaxDesiatov deleted the maxd/atomics branch October 10, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants