-
Notifications
You must be signed in to change notification settings - Fork 19
Fix errors when building WasmKit for WASI #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wasm is the only unsupported platform for WasmKit in the Swift Package Index build matrix. One possible use case is when an implementation for a future Wasm feature is emulated with older Wasm features, when running WasmKit itself in an older Wasm engine. The only remaining roadblock is the lack of `swiftasynccall`, which prevents `_CWasmKit` module from building, but the rest of the modules seem to build fine. For proper testing we also need to fix `swift test` in the Swift toolchain.
kateinoigakukun
approved these changes
Oct 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
token threading is impossible until I unblock tail-call support in the toolchain side, so let's turn it off for now like what we do for windows
MaxDesiatov
commented
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasm is the only unsupported platform for WasmKit in the Swift Package Index build matrix.
One possible use case is using features like WAT assembler or component model tools in the browser.
Another use case could be polyfilling a future Wasm feature running with older Wasm features, when running WasmKit itself in an older Wasm engine.
For proper testing we also need to fix
swift test
in the Swift toolchain.