GDB RP: support qWasmCallStack and debugger breakpoints
#212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
commented
Oct 27, 2025
MaxDesiatov
commented
Oct 27, 2025
MaxDesiatov
commented
Oct 27, 2025
MaxDesiatov
commented
Oct 27, 2025
MaxDesiatov
commented
Oct 27, 2025
MaxDesiatov
commented
Oct 27, 2025
MaxDesiatov
commented
Oct 27, 2025
MaxDesiatov
commented
Oct 27, 2025
MaxDesiatov
commented
Oct 27, 2025
Until swiftlang/swift@b219d40 is tagged, CI with nightly snapshots off `main` keeps crashing.
For some reason `link-secret-dir-b/secret-c.txt` started throwing `.ELOOP` instead of `.ENOTDIR` in https://github.com/swiftwasm/WasmKit/actions/runs/18847983546/job/53777014067
MaxDesiatov
commented
Oct 27, 2025
MaxDesiatov
commented
Oct 27, 2025
MaxDesiatov
commented
Oct 27, 2025
This reverts commit e81f68e.
MaxDesiatov
commented
Oct 28, 2025
|
|
||
| /// Two-way mapping between Wasm and internal iseq bytecode instructions. The implementation of the mapping | ||
| /// is private and is empty when `WasmDebuggingSupport` package trait is disabled. | ||
| struct DebuggerInstructionMapping { |
There was a problem hiding this comment.
Nice side-effect of moving to a separate type is that it's easier to switch to an empty implementation of the mapping based on package traits.
@kateinoigakukun I hope this addresses your review feedback, let me know if anything else is needed to move this forward.
kateinoigakukun
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes basic tests for breakpoints.
Android CI failure fixed in #216.
Fixing
mainsnapshot CI failures depends on an inclusion of swiftlang/swift@b219d40 in a subsequent snapshot.