[Gardening] Remove remaining casting artifacts

Author: CodaFi

lib/AST/ASTDumper.cpp

@@ -716,7 +716,7 @@ namespace {
 
       if (auto *var = dyn_cast<VarDecl>(VD)) {
         PrintWithColorRAII(OS, TypeColor) << " type='";
-        if (auto varTy = var->hasInterfaceType())
+        if (var->hasInterfaceType())
           var->getType().print(PrintWithColorRAII(OS, TypeColor).getOS());
         else
           PrintWithColorRAII(OS, TypeColor) << "<null type>";

lib/AST/AccessRequests.cpp

@@ -213,7 +213,7 @@ DefaultAndMaxAccessLevelRequest::evaluate(Evaluator &evaluator,
 
   AccessLevel maxAccess = AccessLevel::Public;
 
-  if (GenericParamList *genericParams = ED->getGenericParams()) {
+  if (ED->getGenericParams()) {
     // Only check the trailing 'where' requirements. Other requirements come
     // from the extended type and have already been checked.
     DirectlyReferencedTypeDecls typeDecls =

lib/AST/Module.cpp

@@ -1218,7 +1218,7 @@ ModuleDecl::ReverseFullNameIterator::operator++() {
   if (!current)
     return *this;
 
-  if (auto *swiftModule = current.dyn_cast<const ModuleDecl *>()) {
+  if (current.is<const ModuleDecl *>()) {
     current = nullptr;
     return *this;
   }

lib/AST/Type.cpp

@@ -2023,7 +2023,7 @@ getObjCObjectRepresentable(Type type, const DeclContext *dc) {
   // DynamicSelfType is always representable in Objective-C, even if
   // the class is not @objc, allowing Self-returning methods to witness
   // @objc protocol requirements.
-  if (auto dynSelf = type->getAs<DynamicSelfType>())
+  if (type->is<DynamicSelfType>())
     return ForeignRepresentableKind::Object;
 
   // @objc classes.
@@ -4098,7 +4098,7 @@ case TypeKind::Id:
     auto fnTy = cast<SILFunctionType>(base);
     bool changed = false;
 
-    if (auto subs = fnTy->getSubstitutions()) {
+    if (fnTy->getSubstitutions()) {
 #ifndef NDEBUG
       // This interface isn't suitable for updating the substitution map in a
       // substituted SILFunctionType.

lib/AST/TypeCheckRequests.cpp

@@ -363,7 +363,7 @@ SourceLoc WhereClauseOwner::getLoc() const {
 
 void swift::simple_display(llvm::raw_ostream &out,
                            const WhereClauseOwner &owner) {
-  if (auto where = owner.source.dyn_cast<TrailingWhereClause *>()) {
+  if (owner.source.is<TrailingWhereClause *>()) {
     simple_display(out, owner.dc->getAsDecl());
   } else if (owner.source.is<SpecializeAttr *>()) {
     out << "@_specialize";

lib/IRGen/IRGenMangler.cpp

@@ -120,7 +120,7 @@ IRGenMangler::withSymbolicReferences(IRGenModule &IGM,
       }
 
       return true;
-    } else if (auto opaque = s.dyn_cast<const OpaqueTypeDecl *>()) {
+    } else if (s.is<const OpaqueTypeDecl *>()) {
       // Always symbolically reference opaque types.
       return true;
     } else {