Skip to content

Commit 48558f3

Browse files
authored
Merge pull request swiftlang#33950 from gottesmm/pr-4bccd8250f399d6de00468d798d40b170fe4edf2
[build-script-impl] Add a comment explaining why an option isn't truly dead as per reviewers suggestion.
2 parents 9d4062a + 5717d87 commit 48558f3

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

utils/build-script-impl

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1797,6 +1797,12 @@ for host in "${ALL_HOSTS[@]}"; do
17971797
"${swift_cmake_options[@]}"
17981798
)
17991799

1800+
# NOTE: This is not a dead option! It is relied upon for certain
1801+
# bots/build-configs!
1802+
#
1803+
# TODO: In the future when we are always cross compiling and
1804+
# using Toolchain files, we should put this in either a
1805+
# toolchain file or a cmake cache.
18001806
if [[ "${BUILD_TOOLCHAIN_ONLY}" ]]; then
18011807
cmake_options+=(
18021808
-DSWIFT_TOOL_SIL_OPT_BUILD=FALSE

0 commit comments

Comments
 (0)