Sync date part of SDK version with the base tag #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using the date SDK was built but it was not the same as the date snapshot toolchain was built. This was usually causing the SDK version to be off by one day from the toolchain version. Although SDK version and toolchain version are not directly related and there is no guarantee that they have 1:1 mapping (multiple SDK snapshots can be built with the same toolchain snapshot), it is better to have them in sync to avoid confusion.
Home1730
reviewed
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using the date SDK was built but it was not the same as the date snapshot toolchain was built. This was usually causing the SDK version to be off by one day from the toolchain version. Although SDK version and toolchain version are not directly related and there is no guarantee that they have 1:1 mapping (multiple SDK snapshots can be built with the same toolchain snapshot), it is better to have them in sync to avoid confusion.