Red / green marker for evaluation#424
Merged
christianabbet merged 8 commits intomainfrom Mar 30, 2026
Merged
Conversation
Coverage Report •
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
AgathaSchmidt
approved these changes
Mar 19, 2026
Collaborator
AgathaSchmidt
left a comment
There was a problem hiding this comment.
Looks good to me, works well.
Only one note: When looking at this files and evaluating it we should have in mind that when no ground truth is available, it is also marked as red. e.g. no material description available for Thurgau, so when we see that everything is red, we should not misinterpret it.
stijnvermeeren-swisstopo
requested changes
Mar 24, 2026
Collaborator
stijnvermeeren-swisstopo
left a comment
There was a problem hiding this comment.
The visualizations look good again, but I think that the code does not yet separate the evaluation of individual files and the aggregation of statistics over all files cleanly enough...
stijnvermeeren-swisstopo
approved these changes
Mar 30, 2026
Collaborator
stijnvermeeren-swisstopo
left a comment
There was a problem hiding this comment.
Thanks for creating the follow-up issue. This PR can be merged like this as far as I'm concerned :).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #398
Description
Introduces
evaluate_single_predictionto run per-file evaluation on the fly as predictions are produced, enabling red/green markers in drawn output without waiting for the full pipeline to complete.Also refactors how
GroundTruthis constructed and passed through the pipeline. Itt is now built once and passed as an object rather than passing the path repeatedly.Design rationale
Per-file evaluation is needed only for drawing (red/green markers). At the end of the script,
evaluate_all_predictionsre-runs over all files to compute overall metrics. This avoids changing the return type of the extraction pipeline to an already-evaluated object. This would require modifying the core logic shared by both the metadata and geology pipelines, resulting in heavy changes across both and introduce potential bugs.Output example