Conversation
Closed
karpdave
reviewed
Aug 25, 2025
src/npa_howtopay/model.py
Outdated
| npas_this_year, year, input_params.shared.npa_install_costs, input_params.shared.npa_lifetime | ||
| ) | ||
| if scenario_params.gas_electric == "gas": | ||
| gas_capex_projects = gas_capex_projects.vstack(npa_capex) |
Contributor
There was a problem hiding this comment.
Nit: change to pl.concat to match usage in line 115 where we are also just tacking on additional rows to an existing df. Also in line 97
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked in the capex function to run model and passed matching input params
should only need to review
model.py