Merged
Conversation
Contributor
karpdave
commented
Aug 26, 2025
karpdave
commented
- Handles cost_inflation, using a single value for all inflation numbers
- Provides functions for generating npa_projects, including dummy rows that represent scattershot electrification
- Updates npa_project compute functions to handle the existence of scattershot electrification in the df (N.B.: Maybe should just keep track of these elsewhere instead?)
- Updates capex_project.py to have a class CapexProject with a to_df() function, for safety (?)
- Moves relevant helper functions for npa projects dfs into npa_project.py
karpdave
commented
Aug 27, 2025
| original_cost: float = field(validator=validators.ge(0.0)) | ||
| depreciation_lifetime: int = field(validator=validators.ge(1)) | ||
|
|
||
| def to_df(self) -> pl.DataFrame: |
Contributor
Author
There was a problem hiding this comment.
Ohh no, I did a git bad and pushed to main not this branch. So yea absolutely, but this is missing most recent commits
alxsmith
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.