Merged
Conversation
…nce in 1 chain. break out functions for better readability
karpdave
approved these changes
Aug 28, 2025
src/npa_howtopay/model.py
Outdated
| ) | ||
| .alias("nonconverts_gas_bill_per_user"), | ||
| pl.lit(0).alias("converts_gas_bill_per_user"), | ||
| pl.struct(["electric_inflation_adjusted_revenue_requirement", "electric_num_users"]) |
Contributor
There was a problem hiding this comment.
nit: electric_bill_per_user calc belongs in section Fifth
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed mostly minor bugs
Big refactor of compute bills - had to do separate method chains because polars cannot create and reference a new column in one chain, broke out calculations as functions so they are easier to read and can be explicitly tested
lots of deptry nonsense
added run_example.py - its messy but confirms the code can run