Conversation
|
Note that this changes the interface slightly, so that we only pass the parameters we need to the functions in capex_project.py, rather than passing the entire InputParams dataclass I did not updated model.py to reflect this (to avoid potential merge conflict), but I can if preferred |
alxsmith
left a comment
There was a problem hiding this comment.
LGTM can we add some basic test functions that read dummy data and produce expected results for the capex funcs?
| pass | ||
| def get_non_lpp_gas_capex_projects( | ||
| year: int, | ||
| current_ratebase: float, |
There was a problem hiding this comment.
@karpdave where does current_ratebase come from? in year 1 i imagine its an input but then in year 2 does it need to reference a value from its own output df?
There was a problem hiding this comment.
I think the user (i.e., model.py) computes it and passes. So imagine something like:
`this_year_non_lpp_projects = get_non_lpp_gas_capex_projects(year, compute_ratebase_from_capex_projects(gas_capex_projects, year))
gas_capex_projects = gas_capex_projects.vstack(this_year_non_lpp_projects)
`
My hope was that all of the "get" functions don't require passing a df, while the "compute" functions do, for flexibility
Will do |
No description provided.