Skip to content

implement functions in capex_project#7

Merged
karpdave merged 8 commits intomainfrom
capex_project_ticket
Aug 26, 2025
Merged

implement functions in capex_project#7
karpdave merged 8 commits intomainfrom
capex_project_ticket

Conversation

@karpdave
Copy link
Copy Markdown
Contributor

No description provided.

@karpdave karpdave requested a review from alxsmith August 22, 2025 16:59
@karpdave karpdave linked an issue Aug 22, 2025 that may be closed by this pull request
@karpdave
Copy link
Copy Markdown
Contributor Author

Note that this changes the interface slightly, so that we only pass the parameters we need to the functions in capex_project.py, rather than passing the entire InputParams dataclass

I did not updated model.py to reflect this (to avoid potential merge conflict), but I can if preferred

Copy link
Copy Markdown
Contributor

@alxsmith alxsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM can we add some basic test functions that read dummy data and produce expected results for the capex funcs?

pass
def get_non_lpp_gas_capex_projects(
year: int,
current_ratebase: float,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karpdave where does current_ratebase come from? in year 1 i imagine its an input but then in year 2 does it need to reference a value from its own output df?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the user (i.e., model.py) computes it and passes. So imagine something like:

`this_year_non_lpp_projects = get_non_lpp_gas_capex_projects(year, compute_ratebase_from_capex_projects(gas_capex_projects, year))

gas_capex_projects = gas_capex_projects.vstack(this_year_non_lpp_projects)
`

My hope was that all of the "get" functions don't require passing a df, while the "compute" functions do, for flexibility

@karpdave
Copy link
Copy Markdown
Contributor Author

LGTM can we add some basic test functions that read dummy data and produce expected results for the capex funcs?

Will do

@karpdave karpdave merged commit 950f51d into main Aug 26, 2025
0 of 7 checks passed
@karpdave karpdave deleted the capex_project_ticket branch August 26, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement functions in capex_project.py

2 participants