Conversation
Closed
karpdave
reviewed
Aug 25, 2025
src/npa_howtopay/params.py
Outdated
| pipeline_replacement_lifetime: float | ||
| pipeline_maintenance_cost_pct: float | ||
| baseline_non_lpp_gas_ratebase_growth: float | ||
| baseline_gas_lpp_costs_per_year: float |
Contributor
There was a problem hiding this comment.
Dupe with TimeSeriesParams: gas_bau_lpp_costs_per_year
Contributor
|
In spreadsheet, the thing called inflation_rate is only used for the
conversion to 2025 dollars, so I think this collapses into the NPV thing
you are describing
…On Mon, Aug 25, 2025, 3:55 PM Alex Smith ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/npa_howtopay/params.py
<#9 (comment)>
:
> inflation_rate: float
cost_inflation_rate: float
+ npa_lifetime: float
+ npa_install_costs: float
+ discount_rate: float
i was thinking we have inflation rate but also need discount rate for any
NPV calculations. But that may have been confusion on my part
—
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AN7F3GYY6JD44CW6WF6YVOD3PNS35AVCNFSM6AAAAACEYKZWWOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCNJSHAZTCOJZG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
…rams, sorted inputs alphabetically for easier reference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Organized input parameters into groups, define functions to read from yaml
NOTE - i merged in other feature branches so it looks like a lot of changes but you should only focus on
data/sample.yamlandparams.pyfor this PRWe can have pre-packaged yamls with defined starting inputs. those are called by passing a
run_namewhich is the file name for the yaml. it will auto populate the input classes and then join them into a single InputParams class nested by groupStill not sure exactly how we want to handle our timeseries values. I updated the type tags to DFs from Seiries but i think the NPA one will make more sense once we start defining that class