Make q, k, and v contiguous to get better performance for normalize#56
Open
CaoE wants to merge 1 commit intoswz30:mainfrom
Open
Make q, k, and v contiguous to get better performance for normalize#56CaoE wants to merge 1 commit intoswz30:mainfrom
CaoE wants to merge 1 commit intoswz30:mainfrom
Conversation
Eslzzyl
added a commit
to Eslzzyl/Restormer
that referenced
this pull request
Jan 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make q, k, and v contiguous to get better performance for normalize.
After the rearrange operations for q, k, and v, normalizations on the last dim for q and k will be applied. The non-contiguous memory format makes the performance of normalize on the last dim poor.