Skip to content

Check if rewrite is an array #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ajaydsouza wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check if rewrite is an array #753

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion inc/classes/admin/settings/listedit.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,7 @@ public function output_column_contents_for_term( $string, $column_name, $term_id

$memo['tax_object'] ??= \get_taxonomy( $taxonomy );
$memo['permastruct'] ??= Meta\URI\Utils::get_url_permastruct( $generator_args );
$memo['is_taxonomy_hierarchical'] ??= $memo['tax_object']->hierarchical && $memo['tax_object']->rewrite['hierarchical'];
$memo['is_taxonomy_hierarchical'] ??= $memo['tax_object']?->hierarchical && is_array( $memo['tax_object']->rewrite ) && $memo['tax_object']->rewrite['hierarchical'];
Copy link
Copy Markdown
Owner

@sybrew sybrew Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The null-safe operator is PHP 8.0+ — TSF still supports 7.4, and roughly 8% of active users are still on that version (data obtained via Troy).


$permastruct = $memo['permastruct'];

Expand Down