[go] just call generated hooks when setup company #16863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since the func is in `go-mode-local-vars-hook`. Or rather, this restores the PROPS removed in syl20bnr#13455. Fix yasnippet unavailable in first go-mode buffer.
|
btw, this requires emacs-lsp/lsp-mode#4725, otherwise yasnippet remains unenabled in any buffer (many modes with lsp). |
|
Hi @EasternLi can you advice whether it makes sense to merge your PR without the upstream changes you have mentioned? |
I think you can. This does right and doesn't break new. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since the func is in
go-mode-local-vars-hook.Or rather, this restores the PROPS removed in #13455.
Fix yasnippet unavailable in first go-mode buffer.