[core] Refactor spacemacs/write-custom-settings-to-dotfile#17219
Merged
bcc32 merged 6 commits intosyl20bnr:developfrom Feb 20, 2026
Merged
[core] Refactor spacemacs/write-custom-settings-to-dotfile#17219bcc32 merged 6 commits intosyl20bnr:developfrom
bcc32 merged 6 commits intosyl20bnr:developfrom
Conversation
A user might be visiting it, in which case this behavior is quite annoying, and in any case this is simply not necessary. `enable-command` does not kill the buffer, as an example of convention.
Even if the user has disabled auto indentation of Elisp files on save.
... instead of going through a separate string copy.
bcc32
force-pushed
the
refactor-write-custom
branch
from
969378f to
d5b453f
Compare
Collaborator
Author
|
Seeing no objections, I'm going to merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primarily motivated by fixing a small behavior bug in this function,
where saving the custom settings (such as by custom-save-all)
killed any buffer visiting the dotspacemacs file. This is annoying
when the user is separately visiting that file to edit their configs,
and simply unnecessary.
The remainder of the commits are various cleanups and improvements to
make the code more idiomatic and performant.