[core] Hack load-history for items defined during package init functions#17235
Open
bcc32 wants to merge 1 commit intosyl20bnr:developfrom
Open
[core] Hack load-history for items defined during package init functions#17235bcc32 wants to merge 1 commit intosyl20bnr:developfrom
bcc32 wants to merge 1 commit intosyl20bnr:developfrom
Conversation
Collaborator
Author
|
Sadly, this does not fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Items defined during
my-layer/init-package, such as defuns, defvars,or commands defined by
spacemacs|add-togglehave their definitionfile recorded as
init.el(at the root of the Spacemacs repo) becauseload-file-nameis bound to that value at the time the function iscalled and the definitions are executed. This is unlike the normal
way to define commands which is at the top-level of some file which is
loaded by
load.This PR wraps each init/pre-init/post-init funcall with
configuration-layer//funcall-recording-load-history, which let-bindscurrent-load-listandload-file-nameto capture definitions underthe correct source file, so that
symbol-filereturns the file wherethe definition is actually written, not the one that was being loaded
when the definition was executed.
spacemacs|add-toggleisn't recognized byfind-function-regexp, sofind-function still goes to a slightly imprecise place, but at least
it goes to the right file now, which is a significant improvement.
Close #17234.