feat: pkg/ociplatform for OCI platform comparison#105
Merged
dtrudg merged 1 commit intosylabs:mainfrom Jan 23, 2025
Merged
Conversation
OCI platform handling in ggcr is sometimes incomplete / naive. For example, handling of the variant is not consistent with the normalisation rules that are applied in e.g. Docker, containerd etc. Add functions in a new `pkg/ociplatform` package that perform platform comparison using `github.com/containerd/platforms`, with translation through ggcr <-> spec-go types as necessary.
wobito
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OCI platform handling in ggcr is sometimes incomplete / naive. For example, handling of the variant is not consistent with the normalisation rules that are applied in e.g. Docker, containerd etc.
Add functions in a new
pkg/ociplatformpackage that perform platform comparison usinggithub.com/containerd/platforms, with translation through ggcr <-> spec-go types as necessary.