Handle all outstanding issues #159
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted import path for readPdf.js and repositioned a test case for better organization. Co-authored-by: shtse8 <[email protected]>
|
Cursor Agent can help with this pull request. Just |
|
@cursor check failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix malformed nested test, correct ESM import path, and update error message for URL load failures.
The URL load failure test in
test/handlers/readPdf.test.tswas incorrectly nested within anotherexpect.failblock, preventing it from running. This PR moves it to the top level and updates the expected error message to include the URL for clarity. Additionally, the import path intest/benchmark/readPdf.bench.tswas updated to include the.jsextension for ESM consistency.